-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(op-supervisor): add op-supervisor component #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edobry
force-pushed
the
edobry/op-supervisor
branch
from
December 19, 2024 19:37
27bf7f6
to
07824fd
Compare
mslipper
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good but there are some (what appear to be) extraneous changes in here. Can you comment on what those changes are?
edobry
force-pushed
the
edobry/op-supervisor
branch
from
December 20, 2024 19:10
df0b814
to
a5c62ef
Compare
edobry
force-pushed
the
edobry/op-supervisor
branch
from
January 3, 2025 19:19
ecea25f
to
7c1010e
Compare
mslipper
approved these changes
Jan 3, 2025
auto-merge was automatically disabled
January 6, 2025 17:49
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
op-supervisor
component to the package, along with a newinterop
configuration section. It also wiresop-supervisor
up toop-node
andop-geth
.Example configuration
The configuration options for the
interop
section can be set as follows:Successful logs
After executing
kurtosis run
, theop-supervisor
service printed the following log messages, indicating a successful boot:Metadata
This PR was created in support of: https://github.com/ethereum-optimism/platforms-team/issues/520