feat(sentry): base implementation for proposing blocks on a schedule #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattevans
commented
Nov 5, 2024
mattevans
commented
Nov 5, 2024
mattevans
commented
Nov 5, 2024
Savid
reviewed
Nov 6, 2024
Savid
reviewed
Nov 6, 2024
Savid
reviewed
Nov 6, 2024
pkg/server/service/event-ingester/event/beacon/eth/v2/proposed_validator_block.go
Outdated
Show resolved
Hide resolved
Savid
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #338
Adds the ability to build validator blocks on a schedule and/or interval. Uses
produceBlockV3to produce a block and persists new event (BEACON_API_ETH_V3_VALIDATOR_BLOCK) from it. Notable new fields outside of the common block data are:execution_payload_value: Execution payload value in Wei. Use to determine relative value of execution payload.consensus_payload_ value: Consensus rewards paid to the proposer for this block, in Wei. Use to determine relative value of consensus blocks.As part of this PR,
NewEventBlockFrom{DataVersion}has been refactored slightly to accept aBeaconBlockover aVersionedSignedBeaconBlock, allowing re-use by other event decorators.Configured off by default, enable as per usual via sentry config.