Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that cmd_list is wrong quoted in test/utils.py, and addtest_issues #135

Merged

Conversation

mhchia
Copy link
Collaborator

@mhchia mhchia commented Dec 13, 2018

What was wrong?

How was it fixed?

Cute Animal Picture

put a cute animal picture link inside the parentheses

@mhchia mhchia mentioned this pull request Dec 13, 2018
@mhchia mhchia force-pushed the test/add-whiteblock-issue-reprod-func branch from dd192db to 876a79e Compare December 13, 2018 09:08
Copy link
Collaborator

@NIC619 NIC619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nitpicks

test/test_series.py Outdated Show resolved Hide resolved
test/utils.py Outdated Show resolved Hide resolved
@mhchia mhchia force-pushed the test/add-whiteblock-issue-reprod-func branch from 876a79e to 7f71bd9 Compare December 14, 2018 07:12
@mhchia mhchia changed the base branch from master to testing December 14, 2018 07:14
@mhchia mhchia changed the base branch from testing to master December 14, 2018 07:17
@mhchia
Copy link
Collaborator Author

mhchia commented Dec 14, 2018

Plan: still merge this PR to the master to fix the bug in the existing test_series.py, and rebase the branch testing to master

To `if_start`, as a bool type indicating whether we bootstrap start or
stop
@mhchia mhchia merged commit 516bb1e into ethresearch:master Dec 14, 2018
@mhchia mhchia deleted the test/add-whiteblock-issue-reprod-func branch December 14, 2018 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants