Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new ethstorage-sdk #13

Merged
merged 21 commits into from
Aug 15, 2024
Merged

support new ethstorage-sdk #13

merged 21 commits into from
Aug 15, 2024

Conversation

iteyelmp
Copy link
Collaborator

@iteyelmp iteyelmp commented Jul 15, 2024

support new ethstorage-sdk, support estimated gas

Based on EthStorage-SDK v2, the directory structure of the cli has been adjusted, so the main functions need to be retested.

Local test:

  1. git clone https://github.com/ethstorage/ethfs-cli.git
  2. git checkout -b new origin/new
  3. yarn install
  4. npm link

Test case:

  1. On a chain that supports Blob:
  1. Create a contract.
  2. Set default file
  3. Use calldata to upload file.
  4. Use blob to upload file.
  5. Use calldata to upload files in a folder
  6. Use blob to upload files in a folder
  7. After uploading part of the calldata or blob, terminate the upload task and restart uploading again to test the speed of comparing the uploaded files.
  8. If all functions are normal, the test passes.
  1. On a chain that does not support Blobs.
  1. Create a contract.
  2. Set default file
  3. Use calldata to upload file.
  4. Use calldata to upload the folder
  5. After uploading some files, terminate the upload task and restart uploading again.
  6. If all functions are normal, the test passes.

src/index.js Outdated Show resolved Hide resolved
@iteyelmp iteyelmp requested a review from qzhodl July 29, 2024 02:29
src/utils/uploader.js Outdated Show resolved Hide resolved
src/utils/uploader.js Outdated Show resolved Hide resolved
src/utils/uploader.js Outdated Show resolved Hide resolved
src/utils/uploader.js Show resolved Hide resolved
@qzhodl
Copy link

qzhodl commented Jul 29, 2024

support new ethstorage-sdk, support estimated gas

I think you may need to provide more details about the test plan since there are so many changes in this PR. What use cases do you want to cover, and what are the expected results?

@iteyelmp iteyelmp requested a review from qzhodl August 15, 2024 06:36
@iteyelmp iteyelmp merged commit 2402830 into main Aug 15, 2024
@iteyelmp iteyelmp deleted the new branch August 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants