Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a constant query function to FaultDisputeGameN, modify the attack branch variable to uint256, to unify with other variable types. #66

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

JustXxx
Copy link

@JustXxx JustXxx commented Oct 2, 2024

forge test --mc FaultDisputeGameN_Test

...
[PASS] test_stepAttackDummyClaim_attackBranch1_succeeds() (gas: 1008885)
[PASS] test_stepAttackDummyClaim_attackBranch2_succeeds() (gas: 1008850)
[PASS] test_stepAttackDummyClaim_attackBranch3_succeeds() (gas: 1006917)
[PASS] test_stepAttackDummyClaim_attackDACalldata_succeeds() (gas: 1027855)
Suite result: ok. 71 passed; 0 failed; 0 skipped; finished in 605.46ms (1.81s CPU time)

Ran 1 test suite in 627.54ms (605.46ms CPU time): 71 tests passed, 0 failed, 0 skipped (71 total tests)

forge test --mc FaultDisputeN_1v1_Actors_Test

...
[PASS] test_static_1v1honestRootGenesisAbsolutePrestate_succeeds() (gas: 147880537)
[PASS] test_static_1v1honestRoot_succeeds() (gas: 159001375)
Suite result: ok. 11 passed; 0 failed; 0 skipped; finished in 7.35s (9.85s CPU time)

Ran 1 test suite in 7.37s (7.35s CPU time): 11 tests passed, 0 failed, 0 skipped (11 total tests)

@dajuguan
Copy link

dajuguan commented Oct 3, 2024

Why attack branch variable's type need to be unify with other variable types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants