add inbox-as-contract.md #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qizhou
reviewed
Jul 22, 2024
|
|
||
| The integration mainly includes two parts: | ||
| 1. The [`BatchInboxAddress`](https://github.com/ethereum-optimism/optimism/blob/db107794c0b755bc38a8c62f11c49320c95c73db/op-chain-ops/genesis/config.go#L77) is replaced by an inbox contract to check submission conditions. | ||
| 2. When deriving, op-node should exclude failed batches. |
There was a problem hiding this comment.
Suggested change
| 2. When deriving, op-node should exclude failed batches. | |
| 2. When deriving, op-node should exclude failed batch txs. |
|
|
||
| ## Motivation | ||
|
|
||
| Currently the batch inbox is an EOA, this spec aims to allow the batch inbox to be a contract, to enable customized batch submission conditions like: |
There was a problem hiding this comment.
Suggested change
| Currently the batch inbox is an EOA, this spec aims to allow the batch inbox to be a contract, to enable customized batch submission conditions like: | |
| Currently the batch inbox is an EOA. (What are the pros and cons of EOA? How can we solve the cons?). this spec aims to allow the batch inbox to be a contract, to enable customized batch submission conditions like: |
| ## Motivation | ||
|
|
||
| Currently the batch inbox is an EOA, this spec aims to allow the batch inbox to be a contract, to enable customized batch submission conditions like: | ||
| 1. The batch tx must be signed by a quorom of shared sequencers. |
There was a problem hiding this comment.
Suggested change
| 1. The batch tx must be signed by a quorom of shared sequencers. | |
| - The batch tx must be signed by a quorum of sequencers in a decentralized sequencing network; and/or |
|
|
||
| Currently the batch inbox is an EOA, this spec aims to allow the batch inbox to be a contract, to enable customized batch submission conditions like: | ||
| 1. The batch tx must be signed by a quorom of shared sequencers. | ||
| 2. The batch tx must pay DA fee to EthStorage to enable permanent and decentralized storage. |
There was a problem hiding this comment.
Suggested change
| 2. The batch tx must pay DA fee to EthStorage to enable permanent and decentralized storage. | |
| - The batch tx must call a BLOB storage contract (e.g., EthStorage) with a DA fee, which is further distributed to data nodes that prove BLOB storage over time. |
blockchaindevsh
force-pushed
the
inbox_as_contract
branch
from
a9ec987 to
2e6d983
Compare
qizhou
approved these changes
Jul 23, 2024
|
|
||
| This specification aims to allow the batch inbox to be a contract, enabling customized batch submission conditions such as: | ||
| - Requiring the batch transaction to be signed by a quorum of sequencers in a decentralized sequencing network; or | ||
| - Mandating that the batch transaction call a BLOB storage contract (e.g., EthStorage) with a Data Availability (DA) fee, which is then distributed to data nodes that prove BLOB storage over time. |
There was a problem hiding this comment.
Suggested change
| - Mandating that the batch transaction call a BLOB storage contract (e.g., EthStorage) with a Data Availability (DA) fee, which is then distributed to data nodes that prove BLOB storage over time. | |
| - Mandating that the batch transaction call a BLOB storage contract (e.g., EthStorage) with a long-term storage fee, which is then distributed to data nodes that prove BLOB storage over time. |
|
|
||
| The integration process consists of two primary components: | ||
| 1. Replacement of the [`BatchInboxAddress`](https://github.com/ethereum-optimism/optimism/blob/db107794c0b755bc38a8c62f11c49320c95c73db/op-chain-ops/genesis/config.go#L77) with an inbox contract: The existing `BatchInboxAddress`, which currently points to an Externally Owned Account (EOA), will be replaced by a smart contract. This new inbox contract will be responsible for verifying and enforcing batch submission conditions. | ||
| 2. Modification of the op-node derivation process: The op-node will be updated to exclude failed batch transactions during the derivation process. This change ensures that only successfully executed batch transactions are processed and included in the derived state.. |
There was a problem hiding this comment.
Suggested change
| 2. Modification of the op-node derivation process: The op-node will be updated to exclude failed batch transactions during the derivation process. This change ensures that only successfully executed batch transactions are processed and included in the derived state.. | |
| 2. Modification of the op-node derivation process: The op-node will be updated to exclude failed batch transactions during the derivation process. This change ensures that only successfully executed batch transactions are processed and included in the derived state. |
|
Close since the final version is on branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.