Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update precompile address: point evaluation #21

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Update precompile address: point evaluation #21

merged 3 commits into from
Sep 1, 2023

Conversation

syntrust
Copy link
Contributor

@syntrust syntrust commented Aug 31, 2023 •
edited
Loading

  1. Change the pe precompile address from 0x14 to 0x0a referring to Update EIP-4844: Update precompile address for 4844 ethereum/EIPs#7172
  2. Verify the precompile return value, otherwise ANY address used can pass pointEvaluation()
  3. Extract constants
  4. Passed kzg prover test & mining tests

@syntrust syntrust requested a review from qzhodl August 31, 2023 08:38
@qzhodl qzhodl requested a review from qizhou August 31, 2023 08:57
@syntrust syntrust merged commit b14166d into main Sep 1, 2023
This was referenced Sep 4, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzhodl qzhodl qzhodl approved these changes

@qizhou qizhou qizhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syntrust @qizhou @qzhodl