Support new circuit #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qzhodl
commented
Dec 21, 2023
•
qzhodl
commented
- This PR addresses optimization: build a circuit to verify multiple sampling on multiple blobs #20.
- EthStorageContract supports the old circuit. EthStorageContract2 inherits EthStorageContract, and supports the new circuit.
- TODO: need to fix the UT
syntrust
reviewed
Dec 21, 2023
syntrust
reviewed
Dec 22, 2023
syntrust
approved these changes
Jan 5, 2024
This was referenced Jan 5, 2024
qizhou
reviewed
Jan 16, 2024
| hash0 = keccak256(abi.encode(hash0, encodedSamples[i])); | ||
| } | ||
|
|
||
| require(decodeSample(masks, decodeProof[0]), "decode failed"); |
There was a problem hiding this comment.
I think this is wrong somewhere
- miner is not used in the decoding and proving (as part of the encodingKey).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.