Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve js patch #31

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

nand2
Copy link
Contributor

@nand2 nand2 commented Aug 1, 2024

Hi!

This PR improve the javascript patch in the following ways :

  • Fix the web3:// to https:// conversion when the A tag has elements inside (e.g. <a><span>text</span></a>)
  • Now respect the targetattribute of the A tag (target="_blank" open a new tab)
  • Add support for altering the src attribute of IFRAME tags : convert from web3:// to https://

@qzhodl qzhodl requested a review from syntrust August 1, 2024 10:27
@syntrust
Copy link
Collaborator

syntrust commented Aug 2, 2024

Hi nand,
The change looks good to me.
I was just wondering should the patchHTMLFile be improved continuously, is it a good idea to make it a standalone module outside the protocol part? Hopefully, this is not the case.

@syntrust syntrust merged commit 75442f6 into ethstorage:main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants