Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #6

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Update dependencies #6

merged 1 commit into from
Oct 24, 2016

Conversation

garyb
Copy link
Contributor

@garyb garyb commented Oct 23, 2016

For PureScript 0.10 compatibility.

Also, just out of interest, is there much benefit to ApF's values being thunked?

@ethul
Copy link
Owner

ethul commented Oct 24, 2016

Thanks for the updates!

I thunked ApF to align with scalaz's Ap, but I am open to ideas for the representation.

@ethul ethul merged commit 9ccd7db into ethul:master Oct 24, 2016
@garyb
Copy link
Contributor Author

garyb commented Oct 24, 2016

I just wondered, it's not something I've thought deeply about! Before I was reminded of this library I'd implemented the same formulation but without the thunks.

@garyb garyb deleted the 0.10-updates branch October 24, 2016 15:13
@ethul
Copy link
Owner

ethul commented Oct 24, 2016

Ah, got it. Might be an idea to explore. I'd have to put more thought into it too!

@garyb
Copy link
Contributor Author

garyb commented Oct 24, 2016

Could you make a release for these changes please? Unless performance becomes a problem I'm probably not going to give much thought to the implementation in the near future. 😄

@ethul
Copy link
Owner

ethul commented Oct 24, 2016

Just made the release. Thanks!

@ethul
Copy link
Owner

ethul commented Oct 25, 2016

Will do! Sorry for the delay.

On Monday, 24 October 2016, Gary Burgess notifications@github.com wrote:

Could you make a release for these changes please? Unless performance
becomes a problem I'm probably not going to give much thought to the
implementation in the near future. 😄


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVYy0_RwTvp7PIfGVdHTVAL_EHTsXvgks5q3TmxgaJpZM4KeQhm
.

@garyb
Copy link
Contributor Author

garyb commented Oct 25, 2016

You already did so yesterday, thanks!

@ethul
Copy link
Owner

ethul commented Oct 25, 2016

Indeed!

Will do! Sorry for the delay.

That was sent yesterday as an email reply. Odd how it only showed up today. Sorry for the confusion.

@garyb
Copy link
Contributor Author

garyb commented Oct 25, 2016

Ah right 😄 probably down to the recent DNS/connectivity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants