-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI/CD for Helm charts #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
helm/fides
The Fides Helm Chart
labels
Nov 29, 2022
RobertKeyser
changed the title
feat: switch to chart-releaser-action
Improve CI/CD for Helm charts
Nov 30, 2022
RobertKeyser
added a commit
to ethyca/fides
that referenced
this pull request
Dec 1, 2022
7 tasks
daveqnet
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR improves the CI/CD/release process for versions of the Fides Helm chart.
A few things happening here:
gh-pages
branch) to serve theindex.yaml
file.appVersion
to the released Fides version and also incrementing the Helm Chart's semver-based version. This might get a bit cumbersome if we're also working on PRs and a new version of Fides is released, but I think it might be a good way of helping the Helm chart stay up-to-date.Pre-merge Checklist