Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI/CD for Helm charts #6

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Improve CI/CD for Helm charts #6

merged 7 commits into from
Dec 1, 2022

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Nov 29, 2022

Description of Changes

This PR improves the CI/CD/release process for versions of the Fides Helm chart.

A few things happening here:

  • Switching to the pre-made GH Action workflow for chart releaser. This will (in addition to adding to the GH releases) curate the chart repository so it can be easily pulled into other projects. This uses the GitHub Pages (via the gh-pages branch) to serve the index.yaml file.
  • Improve usability documentation
  • Automatically open a PR when there's a new version of Fides released (will also need a corresponding workflow on the Fides repo's GH Actions). It does this by incrementing the chart's appVersion to the released Fides version and also incrementing the Helm Chart's semver-based version. This might get a bit cumbersome if we're also working on PRs and a new version of Fides is released, but I think it might be a good way of helping the Helm chart stay up-to-date.

Pre-merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Relevant Follow-Up Issues Created

@RobertKeyser RobertKeyser self-assigned this Nov 29, 2022
@github-actions github-actions bot added the ci/cd label Nov 29, 2022
@github-actions github-actions bot added documentation Improvements or additions to documentation helm/fides The Fides Helm Chart labels Nov 29, 2022
@github-pages github-pages bot temporarily deployed to github-pages November 30, 2022 17:37 Inactive
@RobertKeyser RobertKeyser changed the title feat: switch to chart-releaser-action Improve CI/CD for Helm charts Nov 30, 2022
@RobertKeyser RobertKeyser marked this pull request as ready for review November 30, 2022 18:49
@RobertKeyser RobertKeyser requested a review from a team as a code owner November 30, 2022 18:49
RobertKeyser added a commit to ethyca/fides that referenced this pull request Dec 1, 2022
Copy link
Contributor

@daveqnet daveqnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@RobertKeyser RobertKeyser merged commit 2a89e4c into main Dec 1, 2022
@RobertKeyser RobertKeyser deleted the rk-cr branch December 1, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd documentation Improvements or additions to documentation helm/fides The Fides Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants