Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
adamsachs committed Jun 14, 2024
1 parent 1c1c956 commit 1c76a85
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def test_search_system_type(self, api_client, generate_auth_header, url):
resp = api_client.get(url + "system_type=database", headers=auth_header)
assert resp.status_code == 200
data = resp.json()["items"]
assert len(data) == 11
assert len(data) == 12

def test_search_system_type_and_connection_type(
self,
Expand Down
12 changes: 6 additions & 6 deletions tests/ops/util/test_storage_authenticator.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import pytest
from botocore.exceptions import NoCredentialsError

from fides.api.common_exceptions import StorageUploadError
from fides.api.schemas.storage.storage import (
Expand All @@ -23,12 +24,11 @@ def tests_unsupported_storage_secret_type_error(self):
)

def tests_automatic_auth_method(self, loguru_caplog):
get_aws_session(
AWSAuthMethod.AUTOMATIC.value, # type: ignore
{StorageSecrets.AWS_ACCESS_KEY_ID: "aws_access_key_id"},
)

assert "created automatic session" in loguru_caplog.text
with pytest.raises(NoCredentialsError):
get_aws_session(
AWSAuthMethod.AUTOMATIC.value, # type: ignore
{StorageSecrets.AWS_ACCESS_KEY_ID: "aws_access_key_id"},
)

def test_secrets_are_valid_bad_storage_type(self):
with pytest.raises(ValueError):
Expand Down

0 comments on commit 1c76a85

Please sign in to comment.