Fix incorrect add icon sizing (#4975)

CHANGELOG.md

@@ -29,6 +29,7 @@ The types of changes are:
 - Fixed an issue where the GPP signal status was prematurely set to `ready` in some scenarios [#4957](https://github.com/ethyca/fides/pull/4957)
 - Removed exteraneous `/` from the several endpoint URLs [#4962](https://github.com/ethyca/fides/pull/4962)
 - Fixed and optimized Database Icon SVGs used in Datamap [#4969](https://github.com/ethyca/fides/pull/4969)
+- Fixed "add" icons on some buttons being wrong size [#4975](https://github.com/ethyca/fides/pull/4975)
 
 ## [2.38.0](https://github.com/ethyca/fides/compare/2.37.0...2.38.0)
 

clients/admin-ui/src/features/common/ScrollableList.tsx

@@ -1,6 +1,5 @@
 import { Select } from "chakra-react-select";
 import {
-  AddIcon,
   Box,
   Button,
   ChakraProps,
@@ -9,6 +8,7 @@ import {
   Flex,
   IconButton,
   List,
+  SmallAddIcon,
   Text,
 } from "fidesui";
 import { motion, Reorder, useDragControls } from "framer-motion";
@@ -142,7 +142,7 @@ const ScrollableListAdd = ({
       w="full"
       size="sm"
       variant="outline"
-      rightIcon={<AddIcon boxSize={3} />}
+      rightIcon={<SmallAddIcon boxSize={4} />}
       data-testid={`add-${baseTestId}`}
     >
       {label}

clients/admin-ui/src/features/common/custom-fields/index.ts

@@ -2,9 +2,7 @@ export * from "./ChooseFromLibrary";
 export * from "./constants";
 export * from "./CreateCustomFields";
 export * from "./CreateCustomLists";
-export * from "./CustomFieldsButton";
 export * from "./CustomFieldsList";
-export * from "./CustomFieldsModal";
 export * from "./helpers";
 export * from "./hooks";
 export * from "./Layout";

clients/admin-ui/src/features/system/dictionary-data-uses/EmptyTableState.tsx

@@ -1,8 +1,8 @@
 import {
-  AddIcon,
   Box,
   Button,
   HStack,
+  SmallAddIcon,
   Stack,
   Text,
   WarningTwoIcon,
@@ -45,7 +45,7 @@ const EmptyTableState = ({ title, description, handleAdd }: Props) => (
             fontWeight="semibold"
             data-testid="add-btn"
             onClick={handleAdd}
-            rightIcon={<AddIcon boxSize={2} />}
+            rightIcon={<SmallAddIcon boxSize={4} />}
           >
             Add data use
           </Button>

clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationDisplayGroup.tsx

@@ -1,5 +1,4 @@
 import {
-  AddIcon,
   Box,
   Button,
   DeleteIcon,
@@ -9,6 +8,7 @@ import {
   IconButton,
   LinkBox,
   LinkOverlay,
+  SmallAddIcon,
   Spacer,
   Stack,
   Text,
@@ -165,7 +165,7 @@ export const PrivacyDeclarationDisplayGroup = ({
             backgroundColor="primary.800"
             color="white"
             fontWeight="600"
-            rightIcon={<AddIcon />}
+            rightIcon={<SmallAddIcon boxSize={4} />}
             data-testid="add-btn"
           >
             Add data use