Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pool Size and Max Overflow Config for CTL Engines #2557

Open
pattisdr opened this issue Feb 9, 2023 · 0 comments
Open

Add Pool Size and Max Overflow Config for CTL Engines #2557

pattisdr opened this issue Feb 9, 2023 · 0 comments

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Feb 9, 2023

Is your feature request related to a specific problem?

Related comment: #2511

We recently added the ability to configure the pool_size and max_overflow on Sqlalchemy engines created ops-side, but the ctl side also has engines that are not yet configurable.

The consequences of having low limits here is that users can hit QueuePool errors when there are a small number of simultaneous connections on the database.

Describe the solution you'd like

Ideally, we'd consolidate some of the ctl and ops engines (ctl side also has asynchronous engines) while we're at it too. A quick change would be just making the ctl engines configurable.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants