Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide config overrides for db engine pool params #2511

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Feb 6, 2023

Closes #2507

Doc updates are in https://github.com/ethyca/fidesdocs/pull/52

Code Changes

  • provide database config properties to allow user configurability of pool_size and max_overflow tunings for the app db engines used by fides
    • a separate pair of settings for both types of engines that our application creates: the engine used generally by the fides API (database.api_engine_pool_size and database.api_engine_max_overflow), and the engine used by specific celery tasks/processes (database.task_engine_pool_size and database.task_engine_max_overflow)

Steps to Confirm

Pre-Merge Checklist

@adamsachs adamsachs linked an issue Feb 6, 2023 that may be closed by this pull request
@adamsachs adamsachs marked this pull request as ready for review February 6, 2023 14:51
@adamsachs adamsachs requested a review from pattisdr February 6, 2023 14:51
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 88.45% // Head: 88.46% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b2ad9dc) compared to base (56b888e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2511   +/-   ##
=======================================
  Coverage   88.45%   88.46%           
=======================================
  Files         328      328           
  Lines       15959    15963    +4     
  Branches     4433     4433           
=======================================
+ Hits        14117    14121    +4     
  Misses       1688     1688           
  Partials      154      154           
Impacted Files Coverage Δ
src/fides/core/config/utils.py 100.00% <ø> (ø)
src/fides/api/ops/api/deps.py 96.15% <100.00%> (ø)
src/fides/api/ops/tasks/__init__.py 82.35% <100.00%> (ø)
src/fides/core/config/database_settings.py 92.00% <100.00%> (+0.69%) ⬆️
src/fides/lib/db/session.py 89.65% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamsachs adamsachs self-assigned this Feb 6, 2023
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we can add a followup for the rest

@adamsachs adamsachs merged commit 6ee0c2a into main Feb 9, 2023
@adamsachs adamsachs deleted the 2507-provide-config-properties-to-set-db-engine-pool_size-and-max_overflow branch February 9, 2023 18:44
@adamsachs
Copy link
Contributor Author

merging while @pattisdr creates a follow up for the valid feedback 🙏

@pattisdr
Copy link
Contributor

pattisdr commented Feb 9, 2023

followup here: #2557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide config properties to set db engine pool_size and max_overflow
2 participants