-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide config overrides for db engine pool params #2511
provide config overrides for db engine pool params #2511
Conversation
Codecov ReportBase: 88.45% // Head: 88.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
=======================================
Coverage 88.45% 88.46%
=======================================
Files 328 328
Lines 15959 15963 +4
Branches 4433 4433
=======================================
+ Hits 14117 14121 +4
Misses 1688 1688
Partials 154 154
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, we can add a followup for the rest
merging while @pattisdr creates a follow up for the valid feedback 🙏 |
followup here: #2557 |
Closes #2507
Doc updates are in https://github.com/ethyca/fidesdocs/pull/52
Code Changes
database
config properties to allow user configurability ofpool_size
andmax_overflow
tunings for the app db engines used by fidesdatabase.api_engine_pool_size
anddatabase.api_engine_max_overflow
), and the engine used by specific celery tasks/processes (database.task_engine_pool_size
anddatabase.task_engine_max_overflow
)Steps to Confirm
fides.toml
or via environment variable and confirm the db engine that's created is using the set valuestask_engine_*
settings) is effectivePre-Merge Checklist
CHANGELOG.md