Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Default Pool Size and Max Overflow #2560

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Feb 9, 2023

Closes Issue: N/A

Code Changes

  • Updates default values for task and api engine pool size and max overflow values

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

Quick follow-up to #2511. Bump pool_size and max_overflow to 50 each as defaults to start.

@pattisdr pattisdr changed the title Bump default pool size and max overflow for both the api and task eng… Increase Default Pool Size and Max Overflow Feb 9, 2023
@pattisdr pattisdr marked this pull request as ready for review February 9, 2023 20:03
@pattisdr pattisdr requested a review from seanpreston February 9, 2023 20:15
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 88.66% // Head: 88.66% // No change to project coverage 👍

Coverage data is based on head (faf99b1) compared to base (6ee0c2a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         331      331           
  Lines       16099    16099           
  Branches     4469     4469           
=======================================
  Hits        14274    14274           
  Misses       1668     1668           
  Partials      157      157           
Impacted Files Coverage Δ
src/fides/lib/db/session.py 89.65% <ø> (ø)
src/fides/core/config/database_settings.py 92.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seanpreston seanpreston merged commit cd6ee67 into main Feb 9, 2023
@seanpreston seanpreston deleted the increase_default_pool_size_and_max_overflow branch February 9, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants