Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Default Pool Size and Max Overflow #2560

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Increase Default Pool Size and Max Overflow #2560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d0875
Bump default pool size and max overflow for both the api and task eng…
pattisdr Feb 9, 2023
faf99b1
Updated changelog.
pattisdr Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ The types of changes are:

### Added

* Added config properties to override database Engine parameters [#2511](https://github.com/ethyca/fides/pull/2511)
* Increased default pool_size and max_overflow to 50 [#2560](https://github.com/ethyca/fides/pull/2560)

* Admin UI
* Create custom fields from a resource screen - Button to Trigger modal [#524](https://github.com/ethyca/fides/pull/2536)
* Create Custom Lists [#525](https://github.com/ethyca/fides/pull/2536)
Expand Down Expand Up @@ -58,8 +61,6 @@ The types of changes are:
### Added
* Add default storage configuration functionality and associated APIs [#2438](https://github.com/ethyca/fides/pull/2438)

### Added
* Added config properties to override database Engine parameters [#2511](https://github.com/ethyca/fides/pull/2511)

## [2.6.1](https://github.com/ethyca/fides/compare/2.6.0...2.6.1)

Expand Down
8 changes: 4 additions & 4 deletions src/fides/core/config/database_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ class DatabaseSettings(FidesSettings):
db: str = "default_db"
test_db: str = "default_test_db"

api_engine_pool_size: int = 5
api_engine_max_overflow: int = 10
task_engine_pool_size: int = 5
task_engine_max_overflow: int = 10
api_engine_pool_size: int = 50
api_engine_max_overflow: int = 50
task_engine_pool_size: int = 50
task_engine_max_overflow: int = 50

sqlalchemy_database_uri: Optional[str] = None
sqlalchemy_test_database_uri: Optional[str] = None
Expand Down
4 changes: 2 additions & 2 deletions src/fides/lib/db/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ def get_db_engine(
*,
config: FidesConfig | None = None,
database_uri: str | URL | None = None,
pool_size: int = 5,
max_overflow: int = 10,
pool_size: int = 50,
max_overflow: int = 50,
) -> Engine:
"""Return a database engine.

Expand Down