Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a generate policy CLI command #284

Closed
ThomasLaPiana opened this issue Dec 9, 2021 · 2 comments
Closed

Implement a generate policy CLI command #284

ThomasLaPiana opened this issue Dec 9, 2021 · 2 comments
Milestone
Backlog

Comments

@ThomasLaPiana
Copy link
Contributor

ThomasLaPiana commented Dec 9, 2021 •
edited by mfbrown
Loading

Originally from #209

Implement a guided walkthrough of building a policy
@ThomasLaPiana
Copy link
Contributor Author

this is still a good idea, but in the meantime we've decided to package/document other good defaulty policies

@ThomasLaPiana ThomasLaPiana added this to the Backlog milestone May 5, 2022
ThomasLaPiana pushed a commit that referenced this issue Aug 17, 2022
@nschoenbrot
163 yaml datasets (#284)
889a950 
* 163 Initial commit showing that yaml dataset can be saved.

* 163 Refactor the yaml dataset endpoint and added pytests.

* 163 Exclude yaml dataset endpoint from open api spec.

Since this endpoint needs to access the request, the open api spec will not be generated correctly. To include this, extend open api: https://fastapi.tiangolo.com/advanced/extending-openapi/

* 163 Formatted with Black.

* 163 Fixes for mypy.

* 163 Added happy path test for patching yaml dataset.

* 163 respond with 415 if the wrong content type is specified a patch to the yaml dataset endpoint.

* 163 Respond with 400 when the dataset yaml cannot be loaded.

* 163 Added example of a YAML PATCH request for dataset. Named: Create/Update Postgres Dataset YAML

* 163 Added example of a YAML PATCH request for dataset. Named: Create/Update Postgres Dataset YAML

* 163 Test patching multiple datasets at a time.

* 163 Return specific yaml error in http response.

* 163 Ran make black.

* 163 Trying to get linter to pass.

Co-authored-by: Nelson Schoenbrot <nelson@ethyca.com>
ThomasLaPiana pushed a commit that referenced this issue Sep 26, 2022
@nschoenbrot
163 yaml datasets (#284)
e002d42 
* 163 Initial commit showing that yaml dataset can be saved.

* 163 Refactor the yaml dataset endpoint and added pytests.

* 163 Exclude yaml dataset endpoint from open api spec.

Since this endpoint needs to access the request, the open api spec will not be generated correctly. To include this, extend open api: https://fastapi.tiangolo.com/advanced/extending-openapi/

* 163 Formatted with Black.

* 163 Fixes for mypy.

* 163 Added happy path test for patching yaml dataset.

* 163 respond with 415 if the wrong content type is specified a patch to the yaml dataset endpoint.

* 163 Respond with 400 when the dataset yaml cannot be loaded.

* 163 Added example of a YAML PATCH request for dataset. Named: Create/Update Postgres Dataset YAML

* 163 Added example of a YAML PATCH request for dataset. Named: Create/Update Postgres Dataset YAML

* 163 Test patching multiple datasets at a time.

* 163 Return specific yaml error in http response.

* 163 Ran make black.

* 163 Trying to get linter to pass.

Co-authored-by: Nelson Schoenbrot <nelson@ethyca.com>
@ThomasLaPiana
Copy link
Contributor Author

this will be done via the UI or default policies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@ThomasLaPiana