Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fides Tutorial: Incorrect Policy in Google Analytics System #297

Closed
RobertKeyser opened this issue Jan 4, 2022 · 0 comments · Fixed by #307
Closed

Fides Tutorial: Incorrect Policy in Google Analytics System #297

RobertKeyser opened this issue Jan 4, 2022 · 0 comments · Fixed by #307
Assignees
@RobertKeyser
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@RobertKeyser
Copy link
Contributor

On the Add Google Analytics > Annotate a Fidesctl System Resource step, the policy included does not have the intentional failure that is illuminated in the next step and rectified on the following page.

The last 3 lines of the policy we demonstrate has the following comments and qualifier:

        # With "IP Anonymization" enabled, IP addresses will be pseudonymized in Google Analytics
        # See https://developers.google.com/analytics/devguides/collection/gtagjs/ip-anonymization
        data_qualifier: aggregated.anonymized.unlinked_pseudonymized.pseudonymized

But the code at the referenced tag has the following, without the comments:

        data_qualifier: aggregated.anonymized.unlinked_pseudonymized.pseudonymized.identified

This breaks the flow of the tutorial, as the fix is already baked into the part that's supposed to fail.
@RobertKeyser RobertKeyser added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 4, 2022
@iamkelllly iamkelllly added this to the Backlog milestone Jan 5, 2022
@RobertKeyser RobertKeyser self-assigned this Jan 5, 2022
RobertKeyser added a commit that referenced this issue Jan 5, 2022
@RobertKeyser
fixed incorrect policy issue in #297
0fa3e95 
I kept the comment with the original one, because I still find it helpful.
@RobertKeyser RobertKeyser mentioned this issue Jan 5, 2022
Merged
4 tasks
PSalant726 pushed a commit that referenced this issue Jan 5, 2022
@RobertKeyser
RK Tutorial Content and Formatting Edits (#307)
9b34692 
* fixed bold in tutorial

* fixed incorrect policy issue in #297

I kept the comment with the original one, because I still find it helpful.

* removed excess comment lines

* fixed syntax highlighting

changed yml --> yaml

* removed newline in summary element

* fixing other syntax highlighting issues

Note: this commit also includes how to articles

* Fixed some other syntax highlighting issue

...and a typo from the last commit :(
@iamkelllly iamkelllly removed this from the Backlog milestone May 25, 2022
ThomasLaPiana pushed a commit that referenced this issue Aug 17, 2022
@elliotbonneville @eastandwestwind
#297 Admin UI v0 (#364)
5daaa97 
* Implements initial privacy center layout

* Implement privacy request modal

* 80 Query Execution BigQuery (#215)

Adds query execution (access and erasure) support for BigQuery.

* makes client_id optional on the PrivacyRequest model

* makes PrivacyRequestCreate.requested_at optional, and default to datetime.utcnow() in the API view

* remove authentication requirements from privacy request create tests

* Update request format slightly

* Switch to babel for compilation to prevent swc build error

* Implement alerts

* Implement optionally required fields

* Move types out of ignored lib folder

* Commit updated files referring to types

* Tweak styles to match Figma designs

* Correct action card layout for all numbers of cards

* Correct logo placement behind alerts

* Correct merge changes

* Implement testing

* Document functionality in README

* Correct README header

* Correct deployment instructions

* Move test setup file to __tests__ folder

* simplify initial config

* Address PR comments

- Remove .env.development file as config lives in `config/config.json`
- Update docs to include instructions to `npm install`
- Add `test:ci` command
- Remove email validation from form
- Add anchor logo on 404 page

* Update README to include note about CSS customization

* Reapply README change

* Remove manual line wrapping from README.md

* Implement UI mock of requests management page

* Improve layout fidelity to designs

* Initialize state management with redux-toolkit

* Implement API mock

* Implement mock server

* Implement login, data retrieval, PII obscuring

* Begin implementing request filters

* Implement ID copying

* Implement searching by ID

* Implement CSV download

* Add policy tag

* adds a data migration to seed some example policies and privacy requests

* autocommit enum field changes so we can use them in the subsequent migration

* Implement Approve / Deny requests

* Implement pagination

* Implement auth redirect, pagination filter reset

* Correct recursive imports by adding type prefix

* Replace hardcoded endpoints with env variables

* Correct tab focus handling on request table rows

* Add shadow to row action hover menu

* Disabled unsupported nav links

* Add border radius to inputs

* Remove unnecessary auth env variable

* Response to review comments

* Expand README

* Revert "adds a data migration to seed some example policies and privacy requests"

This reverts commit 3376b0399d9e90d6aa900eb6583e25a9673baeef.

* Revert "autocommit enum field changes so we can use them in the subsequent migration"

This reverts commit ae8a64810defb376c2ef9099489737942250afae.

* Grab correct reviewer field

Co-authored-by: Catherine Smith <eastandwestwind@gmail.com>
Co-authored-by: Sean Preston <sean@ethyca.com>
ThomasLaPiana pushed a commit that referenced this issue Sep 26, 2022
@elliotbonneville @eastandwestwind
#297 Admin UI v0 (#364)
dd63824 
* Implements initial privacy center layout

* Implement privacy request modal

* 80 Query Execution BigQuery (#215)

Adds query execution (access and erasure) support for BigQuery.

* makes client_id optional on the PrivacyRequest model

* makes PrivacyRequestCreate.requested_at optional, and default to datetime.utcnow() in the API view

* remove authentication requirements from privacy request create tests

* Update request format slightly

* Switch to babel for compilation to prevent swc build error

* Implement alerts

* Implement optionally required fields

* Move types out of ignored lib folder

* Commit updated files referring to types

* Tweak styles to match Figma designs

* Correct action card layout for all numbers of cards

* Correct logo placement behind alerts

* Correct merge changes

* Implement testing

* Document functionality in README

* Correct README header

* Correct deployment instructions

* Move test setup file to __tests__ folder

* simplify initial config

* Address PR comments

- Remove .env.development file as config lives in `config/config.json`
- Update docs to include instructions to `npm install`
- Add `test:ci` command
- Remove email validation from form
- Add anchor logo on 404 page

* Update README to include note about CSS customization

* Reapply README change

* Remove manual line wrapping from README.md

* Implement UI mock of requests management page

* Improve layout fidelity to designs

* Initialize state management with redux-toolkit

* Implement API mock

* Implement mock server

* Implement login, data retrieval, PII obscuring

* Begin implementing request filters

* Implement ID copying

* Implement searching by ID

* Implement CSV download

* Add policy tag

* adds a data migration to seed some example policies and privacy requests

* autocommit enum field changes so we can use them in the subsequent migration

* Implement Approve / Deny requests

* Implement pagination

* Implement auth redirect, pagination filter reset

* Correct recursive imports by adding type prefix

* Replace hardcoded endpoints with env variables

* Correct tab focus handling on request table rows

* Add shadow to row action hover menu

* Disabled unsupported nav links

* Add border radius to inputs

* Remove unnecessary auth env variable

* Response to review comments

* Expand README

* Revert "adds a data migration to seed some example policies and privacy requests"

This reverts commit 4d1628132929312cd749bde49e37c0108bc2bf79.

* Revert "autocommit enum field changes so we can use them in the subsequent migration"

This reverts commit c9a2587b4355e1d5acf37fa28461cbdd61ec931e.

* Grab correct reviewer field

Co-authored-by: Catherine Smith <eastandwestwind@gmail.com>
Co-authored-by: Sean Preston <sean@ethyca.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertKeyser RobertKeyser

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RK Tutorial Content and Formatting Edits ethyca/fides
2 participants
@RobertKeyser @iamkelllly