-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1076] ui/plus: Approve dataset classification button #1129
Merged
ssangervasi
merged 9 commits into
main
from
ssangervasi/fides-1076/approve-dataset-classification-button
Sep 29, 2022
Merged
[1076] ui/plus: Approve dataset classification button #1129
ssangervasi
merged 9 commits into
main
from
ssangervasi/fides-1076/approve-dataset-classification-button
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssangervasi
force-pushed
the
ssangervasi/fides-1076/approve-dataset-classification-button
branch
from
September 28, 2022 01:56
ffbbe93
to
ee00d0e
Compare
allisonking
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! just some nits. awesome tests!
clients/ctl/admin-ui/src/features/dataset/ApproveClassification.tsx
Outdated
Show resolved
Hide resolved
… review This commit does not include the mutation that will be triggered by the button.
…tegories This introduces immer as an explicit dependency, but it was already pulled in by RTK.
ssangervasi
force-pushed
the
ssangervasi/fides-1076/approve-dataset-classification-button
branch
from
September 29, 2022 17:35
ee00d0e
to
9d2c863
Compare
ssangervasi
force-pushed
the
ssangervasi/fides-1076/approve-dataset-classification-button
branch
from
September 29, 2022 18:48
bd09e8e
to
2a25093
Compare
ssangervasi
deleted the
ssangervasi/fides-1076/approve-dataset-classification-button
branch
September 29, 2022 20:20
ssangervasi
added a commit
that referenced
this pull request
Oct 1, 2022
* main: Restrict startsWith comparisons in CheckboxTree more (#1126) [1076] ui/plus: Approve dataset classification button (#1129) Do not rely on order for checking intercept results (#1131) Prepare 1.9.1 release (#1137) Bump fideslang to 1.3.1 (#1136) Prepare changelog for 1.9.0 release (#1134) Update CHANGELOG.md (#1132) Fix bug causing missing datamap rows (#1124) cls migration (#1060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1076
Code Changes
but it was already pulled in by RTK.
ClassifyDataset instead of the instance itself.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Before click:
While loading:
Success: