Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Category Visualization #136

Merged
merged 25 commits into from
Oct 11, 2021
Merged

Data Category Visualization #136

merged 25 commits into from
Oct 11, 2021

Conversation

brentonmallen1
Copy link
Contributor

@brentonmallen1 brentonmallen1 commented Oct 4, 2021

Closes #111

Code Changes

  • Added plotly and pandas dependency
  • Added sankey, sunburst, and text functionality
  • Added categories_figure endpoint to the API
  • Added unit tests for all new functionality

Steps to Confirm

None

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated

Description Of Changes

Added the categories_figure/{figure_type} endpoint to the Fides API. Possible values for
figure type are: ['sankey', 'sunburst', 'text']. A 400 status code will be returned if an invalid
figure type is requested. This functionality is meant to assist in dataset annotation as a
reference open on the side to refer to.

@brentonmallen1 brentonmallen1 changed the title Initial Data Category Visualization Data Category Visualization Oct 4, 2021
Makefile Outdated Show resolved Hide resolved
brentonmallen1 and others added 11 commits October 8, 2021 11:51
* Added plotly dependency
* Added sankey and sunburst functionality
* Created Viz directory to house visualization functionality and rendering templates
* Added functionality to create a nested dictionary
from a data_category.yml file
* Added functionality to generate html to visualize
data_categories by text tree [ci skip]
This reverts commit b37e23abdc468027b6b2e300b091cca8cbdfeb9c.
This reverts commit 10014a73bfdc13c41ec9355a2d0f054d94be0390.
- serves taxonomy visualizations at an endpoint
  - to be altered after integration conversations
* Add Default resources to Fideslang

* add the default taxonomy and load it into the db with the init-db command

* add a healthcheck to the api, fix some makefile commands,  update documentation

Co-authored-by: Thomas La Piana <tal103020@icloud.com>
* Added plotly dependency
* Added sankey and sunburst functionality
* Created Viz directory to house visualization functionality and rendering templates
* refactor to use new default taxonomy implementation
* moved visualization endpoint to api
* moved visualization to core
@brentonmallen1 brentonmallen1 marked this pull request as ready for review October 11, 2021 15:01
@ThomasLaPiana
Copy link
Contributor

@brentonmallen1 all 3 of those resource types use the fides_key/parent_key relationship in an identical way, so i just dropped them in and they work perfectly! going forward, we'll be able to visualize anything hierarchically that follows this pattern

as for the Enum type checking, there probably is but i'm not worried about it in the scope of this PR

* Change figure title based on resource type
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic first contribution to Fidesctl!

@ThomasLaPiana ThomasLaPiana merged commit 4917e76 into main Oct 11, 2021
@ThomasLaPiana ThomasLaPiana deleted the dataset_ui branch October 11, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a visual "taxonomy explorer" UI to the server
2 participants