Documentation updates #91 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Overhaul of tutorial - Add light styling to docs portal - Small updates to README lander - Placeholder for CI reference guide
iamkelllly
commented
Oct 7, 2021
NevilleS
requested changes
Oct 7, 2021
There was a problem hiding this comment.
Thanks for doing this. I added a bunch of notes to see how this feels when we tidy it up.
However, I'm still not sure we've got the right content here; these feel like replays of the demo resources with more information about each type (which is super helpful) but without some clear recommendations for how an engineer would approach creating declarations for their own systems?
earmenda
reviewed
Oct 7, 2021
NevilleS
reviewed
Oct 8, 2021
NevilleS
reviewed
Oct 8, 2021
|
Pushed some CSS fixes, hopefully this is what you were going for |
Added overview to tutorial, placeholder diagrams, channels for README, and content updates
…o kh-tutorialredo
added examples of plain-english policy
reverting to main
reverting to main
|
Alright ready for re-review @NevilleS so we can merge asap. There are only a couple todos in there, but it will get us to the next push from @dougfulton on fides_resources documentation |
NevilleS
approved these changes
Oct 12, 2021
This was referenced Oct 12, 2021
ThomasLaPiana
pushed a commit
that referenced
this pull request
Aug 17, 2022
ThomasLaPiana
pushed a commit
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Code Changes
Steps to Confirm
Pre-Merge Checklist
Description Of Changes
A few todos in there, I'll bump folks directly for input on these.