Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1837/Update cypress tests for okta #1841

Merged
merged 2 commits into from
Nov 22, 2022
Merged

1837/Update cypress tests for okta #1841

merged 2 commits into from
Nov 22, 2022

Conversation

LKCSmith
Copy link
Contributor

@LKCSmith LKCSmith commented Nov 22, 2022 •
edited
Loading

Closes #1837

Code Changes

  • Update fake url to use a legitimate URL in test (to ethyca)
  • Update correct selector on Okta path for scan failure

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@LKCSmith LKCSmith added the bug Something isn't working label Nov 22, 2022
@LKCSmith LKCSmith requested a review from allisonking November 22, 2022 20:35
@LKCSmith LKCSmith self-assigned this Nov 22, 2022
allisonking
allisonking approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray, thank you!!

@LKCSmith LKCSmith merged commit af6036d into main Nov 22, 2022
@LKCSmith LKCSmith deleted the 1837/okta-tests branch November 22, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees

@LKCSmith LKCSmith

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Okta cypress tests are failing
2 participants
@LKCSmith @allisonking