Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing connector icons #2002

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Adding missing connector icons #2002

merged 1 commit into from
Dec 8, 2022

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 8, 2022 •
edited
Loading

Closes #1812

Code Changes

  • Added missing SaaS connector icons
  • Added missing icons for BigQuery and TimescaleDB
  • Left-aligned icons to be consistent with our design mockups

Steps to Confirm

image

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

I had to update the SaasType enum and CONNECTION_TYPE_LOGO_MAP in datastore-connections/constants.ts and add the icons in data/saas/icon and clients/admin-ui/public/images/connector-logos. Ideally the icons shouldn't need to be included with the front-end and instead come from the /connector-types endpoint. I didn't make this additional change to keep the scope manageable.

@galvana galvana linked an issue Dec 8, 2022 that may be closed by this pull request
Update icons for connectors in Fides #1812
Closed
@galvana galvana marked this pull request as ready for review December 8, 2022 21:04
chriscalhoun1974
chriscalhoun1974 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@galvana galvana merged commit 3bb156a into main Dec 8, 2022
@galvana galvana deleted the 1812-update-icons-for-connectors-in-fides branch December 8, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscalhoun1974 chriscalhoun1974 chriscalhoun1974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update icons for connectors in Fides
2 participants
@galvana @chriscalhoun1974