Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-nest ctl core code #2097

Merged
merged 8 commits into from
Dec 21, 2022
Merged

De-nest ctl core code #2097

merged 8 commits into from
Dec 21, 2022

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Dec 20, 2022

Closes #

Code Changes

  • De-nest the fides.core and fides.connectors module from fides.ctl
  • update all of the imports
  • update various hardcoded paths

Steps to Confirm

  • N/A

Pre-Merge Checklist

Description Of Changes

I have organizational OCD, and this has been bothering me

@ThomasLaPiana ThomasLaPiana self-assigned this Dec 20, 2022
@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review December 21, 2022 04:43
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the quickstart and wasn't sure if some of these should be maintained or not yet? https://github.com/ethyca/fides/blob/ThomasLaPiana-denest-ctl/scripts/quickstart.py#L19

update appears the quickstart failed, have to step away for a few but can update when I get back if still away

@ThomasLaPiana
Copy link
Contributor Author

@SteveDMurphy it ran for me locally on this branch 🤔 but I'm not sure it matters anymore either, it's a good q. I'll ask in slack and follow up with another issue if needed

Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through dev, quickstart, test_env and they all check out 👍🏽

We will probably need a follow on issue in fidesplus as well but not sure how we want to handle that today

@ThomasLaPiana
Copy link
Contributor Author

Good call, that'll have to get tackled in a version bump PR

@ThomasLaPiana ThomasLaPiana merged commit d97cbac into main Dec 21, 2022
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-denest-ctl branch December 21, 2022 17:30
@SteveDMurphy
Copy link
Contributor

@SteveDMurphy it ran for me locally on this branch 🤔 but I'm not sure it matters anymore either, it's a good q. I'll ask in slack and follow up with another issue if needed

This was the error before a804822

Traceback (most recent call last):
  File "/fides/scripts/quickstart.py", line 19, in <module>
    from fides.ctl.core.config import get_config
ImportError: cannot import name 'get_config' from 'fides.ctl.core.config' (unknown location)

@ThomasLaPiana
Copy link
Contributor Author

@SteveDMurphy oh good catch, thanks for the fix! I didn't even see you snuck it in there :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants