-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-nest ctl core code #2097
De-nest ctl core code #2097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the quickstart and wasn't sure if some of these should be maintained or not yet? https://github.com/ethyca/fides/blob/ThomasLaPiana-denest-ctl/scripts/quickstart.py#L19
update appears the quickstart failed, have to step away for a few but can update when I get back if still away
@SteveDMurphy it ran for me locally on this branch 🤔 but I'm not sure it matters anymore either, it's a good q. I'll ask in slack and follow up with another issue if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through dev
, quickstart
, test_env
and they all check out 👍🏽
We will probably need a follow on issue in fidesplus
as well but not sure how we want to handle that today
Good call, that'll have to get tackled in a version bump PR |
This was the error before a804822
|
@SteveDMurphy oh good catch, thanks for the fix! I didn't even see you snuck it in there :D |
Closes #
Code Changes
fides.core
andfides.connectors
module fromfides.ctl
Steps to Confirm
Pre-Merge Checklist
Relevant Follow-Up Issues CreatedCHANGELOG.md
Description Of Changes
I have organizational OCD, and this has been bothering me