Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy docs #2137

Closed
wants to merge 7 commits into from
Closed

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jan 5, 2023

EDIT: After further pondering, this PR will be updated to remove the majority of the docs site but leave the autogenerated pieces (API and CLI) and have a simple landing page to direct people to the new docs site

Closes #2021

Code Changes

  • remove all docs
  • remove all docs-related CI jobs
  • remove all docs-related nox commands
  • remove docs compose service

Steps to Confirm

  • do a search for docs in the dir and confirm all remaining instances are unrelated
  • README banner image still shows (this was previously in the docs/ subdir)

Pre-Merge Checklist

Description Of Changes

This PR removes all of the code/logic related to the legacy docs

@ThomasLaPiana ThomasLaPiana self-assigned this Jan 5, 2023
@ThomasLaPiana ThomasLaPiana requested review from sanders41, pattisdr and eastandwestwind and removed request for sanders41 and pattisdr January 5, 2023 04:03
@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review January 5, 2023 04:03
Copy link
Contributor

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

One thing we could do is add an assets directory and put the fides-banner.png in there along with anything else like it that comes up in the future. Not blocking, and not mandatory by any means though.

@ThomasLaPiana
Copy link
Contributor Author

lgtm

One thing we could do is add an assets directory and put the fides-banner.png in there along with anything else like it that comes up in the future. Not blocking, and not mandatory by any means though.

Agreed! Let's keep that in mind for when we add more stuff

@ThomasLaPiana ThomasLaPiana marked this pull request as draft January 10, 2023 02:45
@ThomasLaPiana
Copy link
Contributor Author

Closing this PR as instead we want to reduce the scope of the docs site instead of completely replace it. We also need to point to the new docs site

@ThomasLaPiana ThomasLaPiana mentioned this pull request Jan 18, 2023
9 tasks
@NevilleS NevilleS deleted the ThomasLaPiana-remove-legacy-docs branch March 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all docs now that they've been deprecated
2 participants