Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning when env vars default to blank strings in docker-compose #2188

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jan 10, 2023

Closes #1434

Code Changes

  • Changed :- to - when defaulting to an empty string.

Steps to Confirm

  • Run nox -s dev
  • Verify the following warnings are not present
WARN[0000] The "VAULT_ADDR" variable is not set. Defaulting to a blank string.                                                                                                                                                                                                            
WARN[0000] The "VAULT_TOKEN" variable is not set. Defaulting to a blank string. 
WARN[0000] The "FIDES__CLI__ANALYTICS_ID" variable is not set. Defaulting to a blank string. 
WARN[0000] The "VAULT_NAMESPACE" variable is not set. Defaulting to a blank string. 
WARN[0000] The "FIDES__CLI__ANALYTICS_ID" variable is not set. Defaulting to a blank string. 

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Confirmed that the warnings were not present when running nox -s dev

@sanders41 sanders41 merged commit bfb96e3 into main Jan 10, 2023
@sanders41 sanders41 deleted the ps-env-var-warning branch January 10, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some warnings at startup should instead be info
2 participants