Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2159] "About Fides" page for features and version info #2192

Merged
merged 4 commits into from
Jan 11, 2023
Merged

[2159] "About Fides" page for features and version info #2192

merged 4 commits into from
Jan 11, 2023

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Jan 10, 2023 •
edited
Loading

Closes #2159

Code Changes

  • ui/features: Common health query and version in features
  • ui/management: About page for Fides meta information
  • ui/header: Remove features panel from user menu
  • ui/header: Remove version number from user menu

Steps to Confirm

  • Navigate to /management/about
    • Verify version no
    • Toggle features on/off.
  • Interact with user menu

Pre-Merge Checklist

Description Of Changes

The new page and the reverted menu:

about-fides

@ssangervasi ssangervasi force-pushed the ssangervasi/fides-2159/about-fides-page branch from bd5817f to 94f8776 Compare January 10, 2023 21:27
allisonking
allisonking approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! looks good to go after linting fix

@ssangervasi ssangervasi force-pushed the ssangervasi/fides-2159/about-fides-page branch from 94f8776 to ffc7bff Compare January 10, 2023 22:33
@ssangervasi ssangervasi force-pushed the ssangervasi/fides-2159/about-fides-page branch from ffc7bff to 83366ec Compare January 11, 2023 00:30
@ssangervasi ssangervasi merged commit d055ec2 into main Jan 11, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides-2159/about-fides-page branch January 11, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

@NevilleS NevilleS Awaiting requested review from NevilleS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new "Management > About Fides" page for miscellaneous information
2 participants
@ssangervasi @allisonking