Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1979/Blur after focus state on reprocess button #2199

Merged
merged 4 commits into from
Jan 12, 2023
Merged

Conversation

LKCSmith
Copy link
Contributor

@LKCSmith LKCSmith commented Jan 11, 2023

Closes #1979

The issue is that the ReprocessButton component wasn't picking up the blur event being passed from ButtonGroup when it needs to be passed to it after it handles its click events for reprocessing. This PR explicitly passes the blur to the ReprocessButton component being referenced and calls it after reprocessing steps.

It's not the prettiest thing, so if there's a better way to pass this to the reprocess button, let me know? 👀

Blur.mov

Code Changes

  • Pass blur to ReprocessButton component
  • Add blur function as part of ReprocessButton props (optional)
  • Call blur on approval of request

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@codeclimate
Copy link

codeclimate bot commented Jan 11, 2023

Code Climate has analyzed commit 3d45ee1 and detected 0 issues on this pull request.

View more on Code Climate.

@LKCSmith LKCSmith self-assigned this Jan 11, 2023
@LKCSmith LKCSmith added the bug Something isn't working label Jan 11, 2023
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LKCSmith LKCSmith merged commit 6b60cde into main Jan 12, 2023
@LKCSmith LKCSmith deleted the 1979/dsr-row-state branch January 12, 2023 21:07
@Roger-Ethyca
Copy link
Contributor

verified on test env
Screen Shot 2023-01-18 at 1 28 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a DSR fails - the row in the privacy request dashboard gets stuck in an hover state
3 participants