Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Tutorial Links #220

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fixed Tutorial Links #220

merged 2 commits into from
Nov 10, 2021

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Nov 10, 2021

Closes

Code Changes

  • list your code changes here

  • Repointed https://ethyca.github.io/fides/tutorial/overview/ to https://ethyca.github.io/fides/tutorial/

  • Repointed https://ethyca.github.io/fides/tutorial/ci/ to https://ethyca.github.io/fides/deployment/#step-5-install-fidesctl-cli-on-ci-build-server

  • Repointed https://ethyca.github.io/fides/tutorial/evaluate/ to https://ethyca.github.io/fides/tutorial/pass/#evaluate-the-fidesctl-policies

Steps to Confirm

  • list any manual steps taken to confirm the changes

View the README.md file in this branch and confirm the links work.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated

Description Of Changes

Write some things here about the changes and any potential caveats

Changed the broken links that were in the first paragraph and elsewhere to valid URLs. These might not be the final URLs, but they work.

@RobertKeyser RobertKeyser changed the title fixed link to tutorial overview Fixed Tutorial Links Nov 10, 2021
@RobertKeyser RobertKeyser linked an issue Nov 10, 2021 that may be closed by this pull request
not sure these will be the end-state links, but they at least go to a valid URL.
@RobertKeyser RobertKeyser marked this pull request as ready for review November 10, 2021 18:19
@RobertKeyser RobertKeyser self-assigned this Nov 10, 2021
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

@ThomasLaPiana ThomasLaPiana merged commit 246847e into main Nov 10, 2021
@ThomasLaPiana ThomasLaPiana deleted the rkeyser-fix-tutorial-link branch November 10, 2021 19:38
Copy link
Contributor

@iamkelllly iamkelllly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for this Robert!

@@ -10,7 +10,7 @@

## :zap: Overview

Fides (*fee-dhez*, Latin: Fidēs) is an open-source tool that allows you to easily [declare your systems' privacy characteristics](https://ethyca.github.io/fides/tutorial/system/), [track privacy related changes](https://ethyca.github.io/fides/tutorial/policy/) to systems and data in version control, and [enforce policies](https://ethyca.github.io/fides/tutorial/evaluate/) in both your source code and [your runtime infrastructure](https://ethyca.github.io/fides/tutorial/ci/).
Fides (*fee-dhez*, Latin: Fidēs) is an open-source tool that allows you to easily [declare your systems' privacy characteristics](https://ethyca.github.io/fides/tutorial/system/), [track privacy related changes](https://ethyca.github.io/fides/tutorial/policy/) to systems and data in version control, and [enforce policies](https://ethyca.github.io/fides/tutorial/pass/#evaluate-the-fidesctl-policies) in both your source code and [your runtime infrastructure](https://ethyca.github.io/fides/deployment/#step-5-install-fidesctl-cli-on-ci-build-server).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for using anchors 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links to Tutorial on README.md
3 participants