Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @fidesui/components to match single @fidesui/react version #2271

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Jan 18, 2023

Closes #2268

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

#2268 (comment)

After changes:

npm ls @chakra-ui/provider
admin-ui@ /Users/sebastiansangervasi/co/ethyca/fides/clients/admin-ui
└─┬ @fidesui/react@0.0.20
  ├── @chakra-ui/provider@1.7.9
  ├─┬ @fidesui/react-provider@0.0.18
  │ └── @chakra-ui/provider@1.7.14
  └─┬ @fidesui/react-theme@0.0.7
    └─┬ @chakra-ui/react@1.8.9
      └── @chakra-ui/provider@1.7.14 deduped

2268-del-tax

2268-creat-tax

@ssangervasi ssangervasi changed the title Ssangervasi/fides/2268/chakra versions Update @fidesui/components to match single @fidesui/react version Jan 18, 2023
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the issue for me. Toasts worked locally. Thanks for finding this!!

@ssangervasi
Copy link
Contributor Author

Ok, I've created https://github.com/ethyca/fidesui/pull/38 to remove exact pins of chakra versions from @fidesui/react. I had a feeling those pins were going to cause problems, because generally you want libraries to be as loose as possible (only specify what you definitely need) so that apps can be as specific as they need.

Testing with relative installs has worked so far. Here's my hack for installing the local versions. And here's a script I threw together to look for packages that have multiple versions installed:

npm-dups 'chakra'

# Happy output:
Match: @chakra-ui/provider
Unique

# Unhappy output:
Match: @chakra-ui/provider
2 versions:
@chakra-ui/provider@1.7.14
@chakra-ui/provider@1.7.9

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh what a hero, @ssangervasi !!! went through all the steps and things are working 💯 I'll click through a bit more to make sure nothing else looks off, just leaving a comment first to see if you want to swap out @chakra-ui/utils now

clients/admin-ui/package.json Outdated Show resolved Hide resolved
@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2268/chakra-versions branch from 3a7d947 to 54cc489 Compare January 19, 2023 18:41
@ssangervasi ssangervasi merged commit 3363ced into main Jan 20, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides/2268/chakra-versions branch January 20, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toasts no longer appear
3 participants