-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move packaging
to requirements.txt to fix check_install
#2273
Conversation
…itten by other dependency
I did the |
Hmm, that did it for me and the ci check seems to pass now 🤔 I did also trash my virtual environment to try and recreate how the test is run. If not that, maybe something with a specific Python version? I'm on |
I'm 3.10.9. Trying to recreate my virtual environment now to see what that does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My virtual environment is being slow about reinstalling after re-creating. I'm going to go ahead an approve here since it is passing CI with this change, and gets PRs unblocked.
Virtual environment finished and it still failed, but I would still rather merge this and get CI going again. |
Hmm, interesting for sure - thanks for the review and taking the time to look at it! |
Closes #2272
Code Changes
packaging
torequirements.txt
Steps to Confirm
pip install .
pip list | grep packaging
returns the correct versionPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Found in #2263 and #2226