Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag dataset UX changes #2335

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Feature flag dataset UX changes #2335

merged 5 commits into from
Jan 23, 2023

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jan 23, 2023 •
edited
Loading

Closes fidesplus#539

Code Changes

  • Create new feature flag for dataset ux changes
  • Move recent changes behind feature flag

Steps to Confirm

  • Classify some datasets!
  • Validate the feature flag is enabled
  • Ensure only collection is approved
  • Flip flag and validate an entire dataset is approved (when multiple collections exist)

Pre-Merge Checklist

Description Of Changes

loom video of feature flag in action!

@SteveDMurphy
Copy link
Contributor Author

Previously received some code climate errors - will ignore these for now as we are focused on pytest coverage here

@SteveDMurphy SteveDMurphy self-assigned this Jan 23, 2023
allisonking
allisonking reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, just some suggestions that you don't have to take if you don't want to! going to QA but will approve once I'm done with that 👍

clients/admin-ui/src/features/dataset/helpers.ts Outdated Show resolved Hide resolved
clients/admin-ui/src/features/dataset/ApproveClassification.tsx Outdated Show resolved Hide resolved
allisonking
allisonking approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me!

@SteveDMurphy SteveDMurphy marked this pull request as ready for review January 23, 2023 23:28
@SteveDMurphy SteveDMurphy merged commit fdbb8c5 into main Jan 23, 2023
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-539-fflag-dataset-ux branch January 23, 2023 23:57
SteveDMurphy added a commit that referenced this pull request Jan 24, 2023
@SteveDMurphy @allisonking
Feature flag dataset UX changes (#2335)
72da423 
Co-authored-by: Allison King <allison@ethyca.com>
@SteveDMurphy SteveDMurphy mentioned this pull request Jan 24, 2023
Merged
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

@ssangervasi ssangervasi Awaiting requested review from ssangervasi

Assignees

@SteveDMurphy SteveDMurphy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveDMurphy @allisonking