Remove the action field from Policy manifests, add an OTHER match type
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes all handling of this field, and any relevant documentation.
PSalant726
changed the title
action field from Policy manifests, add an OTHER match type
PSalant726
added
dev experience
earmenda
reviewed
Dec 21, 2021
earmenda
approved these changes
Dec 22, 2021
|
nice! |
ThomasLaPiana
approved these changes
Dec 22, 2021
ThomasLaPiana
pushed a commit
that referenced
this pull request
Aug 17, 2022
…] (#306) * Allow the "after" param to be optionally specified on a saas config endpoint. * WIP If a collection has grouped identity data, meaning it is dependent on other inputs, combine the seed data with the other grouped inputs when processing the data to be fed into the current collection. * Add tests for "after" query param on saas configs and that identity data is grouped with other dependent fields if it is listed as a grouped_input. - Pull identity data off from the data that is passed into the collection, instead of out of the cache for consistency. - Revert a hardcoded static portion of a query param used in local testing. * Make corresponding change to saas dataset. * Remove double quotes. * Fix bad docs merge. * Fix missed import. * Respond to CR.
ThomasLaPiana
pushed a commit
that referenced
this pull request
Sep 26, 2022
…] (#306) * Allow the "after" param to be optionally specified on a saas config endpoint. * WIP If a collection has grouped identity data, meaning it is dependent on other inputs, combine the seed data with the other grouped inputs when processing the data to be fed into the current collection. * Add tests for "after" query param on saas configs and that identity data is grouped with other dependent fields if it is listed as a grouped_input. - Pull identity data off from the data that is passed into the collection, instead of out of the cache for consistency. - Revert a hardcoded static portion of a query param used in local testing. * Make corresponding change to saas dataset. * Remove double quotes. * Fix bad docs merge. * Fix missed import. * Respond to CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
Code Changes
actionfield from Policy manifestsinclusion-->matches(including theInclusionEnum-->MatchesEnum)OTHERmatch type toMatchesEnumSteps to Confirm
matches: OTHER, and determine that evaluations pass/fail as expectedPre-Merge Checklist
Description Of Changes
Completely removes the
actionfield from Policy manifests, since onlyREJECTwas ever a valid value. Going forward, all policies will be assumed toREJECT. Also enables theOTHERmatch type, for privacy declarations not included in the list for the given Policy.