Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable/disable toggle to integration tab #3593

Merged
merged 8 commits into from
Jul 10, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Jun 16, 2023

Closes #3591

Code Changes

  • Because we still have the old connections page I left the enable/disable menu item and simply added the switch

Steps to Confirm

  • Create a system
  • Add an integration
  • run a DSR see the integration listed in the log
  • Disable the integration
  • run a DSR see the integration is no longer listed
  • when enabling/disabling verify the modal is correct and the toggle updates

Pre-Merge Checklist

Description Of Changes

https://www.loom.com/share/2616ee133b69430b9aaf5cfd9b3f28fd?sid=61929e60-e81c-47ee-b64d-585cb9bba423

@cypress
Copy link

cypress bot commented Jun 19, 2023

Passing run #3099 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 70f57ee into cadbea1...
Project: fides Commit: 41d0ab11c3 ℹ️
Status: Passed Duration: 00:54 💡
Started: Jul 10, 2023 7:21 PM Ended: Jul 10, 2023 7:22 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Kelsey-Ethyca Kelsey-Ethyca marked this pull request as ready for review July 10, 2023 19:09
@Kelsey-Ethyca Kelsey-Ethyca merged commit 4f91375 into main Jul 10, 2023
@Kelsey-Ethyca Kelsey-Ethyca deleted the kt-3591-enable-disable-connector branch July 10, 2023 19:26
Kelsey-Ethyca added a commit that referenced this pull request Jul 10, 2023
Co-authored-by: Allison King <allisonjuliaking@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enable/disable button for connectors
2 participants