-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Privacy Action Cards to Grow #3669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertKeyser
requested review from
seanpreston,
NevilleS,
eastandwestwind,
TheAndrewJackson and
allisonking
June 23, 2023 18:47
Hypothetically speaking, if we wanted to eliminate the limit altogether, we could remove the There are a few approaches here:
|
Passing run #2898 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
seanpreston
reviewed
Jun 23, 2023
allisonking
approved these changes
Jun 29, 2023
SteveDMurphy
pushed a commit
that referenced
this pull request
Jun 30, 2023
SteveDMurphy
pushed a commit
that referenced
this pull request
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3668
Description Of Changes
This PR changes the privacy center, allowing the privacy action cards to grow if there is a long description (now unlimited lines) or a title that spans two lines. Before, they were static and would lead to clipping and truncation.
Code Changes
h
property on the flex element withminH
text
elementSteps to Confirm
Default text, everything should look the same
Long descriptions should now truncate at 5 lines instead of 3, grows flexbox
Title that spans two lines now grows flexbox
Pre-Merge Checklist
CHANGELOG.md