Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform null names to an empty string before submission #3683

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 26, 2023

FE fix to get around #3682

Description Of Changes

#3571 refactored the privacy declaration form a bit so that we could include cookies fields. As part of that, there was a change where we only transformed the declaration was being edited, whereas previously we had transformed all declarations prior to submission.

This PR restores doing an additional transform to all declarations right before sending to the API.

Code Changes

  • Add one more transform function

Steps to Confirm

  • Run nox -s fides_env -- prod
  • On one of the existing systems that already has a data use, try to add another data use
  • You should be able to add one without getting any errors

Pre-Merge Checklist

  • All CI Pipelines Succeeded
    * [ ] Issue Requirements are Met --> no they are not! but this is a smaller FE workaround
  • Update CHANGELOG.md

@allisonking allisonking marked this pull request as ready for review June 26, 2023 20:42
@allisonking allisonking requested a review from adamsachs June 26, 2023 20:42
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested locally and looks good, nice work on the super speedy patch!!!

@cypress
Copy link

cypress bot commented Jun 26, 2023

Passing run #2913 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 00ae922 into 3a4798f...
Project: fides Commit: bf556ea9b5 ℹ️
Status: Passed Duration: 01:11 💡
Started: Jun 26, 2023 8:59 PM Ended: Jun 26, 2023 9:00 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking merged commit 50273e6 into main Jun 26, 2023
@allisonking allisonking deleted the aking/3682/privacy-declaration-null-name branch June 26, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants