Updating DSR data pre-processor to support manual data #3693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3686
Description Of Changes
The DSR report builder pre-processes the raw DSR data to separate the collection address into its separate parts, the dataset name and the collection name. The collection address for manual integrations is just the collection name without a dataset. The missing separator
:
from manual collection addresses causes an error when generating the DSR report. The fix uses a default dataset name ofmanual
for manual collection addresses. I understand that using this approach might cause a collision with a non-manual datasets namedmanual
but the product team (@rsilvery) agreed this was acceptable for now.Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md