cascade deletes from system -> connectionconfig -> datasetconfig

[adamsachs]

Closes #3769

Description Of Changes

Updates the ORM backlink relationships between System --> ConnectionConfig and ConnectionConfig --> DatasetConfig to cascade deletes. This effectively ensures, via the ORM layer, that our DELETE /system API will also delete these related integration (i.e. connection) artifacts in the DB, as is expected.

Code Changes

• specify cascade="all, delete", argument for relationships between System --> ConnectionConfig and between ConnectionConfig --> DatasetConfig

Steps to Confirm

• confirm reported bug is fixed:
  • create a system (e.g. type "Domo")
  • create a bogus integration config on that system
  • run a privacy request, see it error out on the Domo integration step (expected)
  • delete the system
  • try running another privacy request. it shouldn't error out, at least not from the Domo integration.
• confirm no other regressions related to system/connection configs
  • try a bunch of CRUD operations on systems thru the UI -- some with no integrations, some with "linked" existing standalone integration, some with "new" integrations
  • try creating a "legacy" standalone connection by flipping the feature flag. ensure CRUD operations on this connection still work as expected

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

[cypress]

Passing run #3122 ↗︎

0

4

0

0

0

Details:

Merge d9740ff into 956745d...
Project: fides	Commit: 0b2e94c62a ℹ️
Status: Passed	Duration: 00:45 💡
Started: Jul 11, 2023 2:06 PM	Ended: Jul 11, 2023 2:07 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[adamsachs]

@galvana the test is just getting hung up here on CI, not sure why - when i execute the test manually, locally, it runs fine. i can dig into it more tomorrow AM my time, but i wanted to flag the PR for you in case you've got any time to review before i pick it back up tomorrow.

from what i can tell in manual testing, this approach works well and i haven't noticed any regressions yet. but the update could have a broader impact and could potentially have unintended side effects. let me know your thoughts if you've got a chance!

[adamsachs]

@galvana the test is just getting hung up here on CI, not sure why - when i execute the test manually, locally, it runs fine. i can dig into it more tomorrow AM my time, but i wanted to flag the PR for you in case you've got any time to review before i pick it back up tomorrow.

from what i can tell in manual testing, this approach works well and i haven't noticed any regressions yet. but the update could have a broader impact and could potentially have unintended side effects. let me know your thoughts if you've got a chance!

pinned down the test issue to be due to the async nature of the endpoint being called -- simplest fix was to move the test to be alongside other "ctl" tests hitting the DELETE /system endpoint, that used similar async testing constructs. running the ctl-unit test suite locally worked well (whereas before running the ops-unit suite was showing similar issues to what was seen in CI). so hopefully 🤞 we're good now!

also completed some regression testing on my fides_env test env, mainly re: UI-based CRUD operations on systems and connections. things looked good there.

i think this is ready for review now (assuming CI passes, which it should now!)

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (956745d) 87.12% compared to head (d9740ff) 87.12%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3771   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         311      311           
  Lines       19072    19072           
  Branches     2462     2462           
=======================================
  Hits        16617    16617           
  Misses       2027     2027           
  Partials      428      428           

Impacted Files	Coverage Δ
src/fides/api/models/connectionconfig.py	97.00% <ø> (ø)
src/fides/api/models/sql_models.py	97.81% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TheAndrewJackson]

💥