Fides ints 62 greenhouse harvestapi access erasure #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #8260 ↗︎
Details:
Review all test suite changes for PR #4945 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4945 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 346 346
Lines 21403 21408 +5
Branches 2825 2826 +1
=======================================
+ Hits 18598 18603 +5
Misses 2308 2308
Partials 497 497 ☔ View full report in Codecov by Sentry. |
galvana
reviewed
Jun 4, 2024
Comment on lines
10
to
17
| - name: domain | ||
| label: The Harvest domain. Default harvest.greenhouse.io | ||
| default_value: harvest.greenhouse.io | ||
| - name: api_key | ||
| label: The Harvest API key processed value. This can be generated by navigating from the Greenhouse main page to Configure >> Dev Center >> API Credential Management and taking note of the Harvest API key value. A colon must be appended and the resulting string encoded base64. Please see the Harvest API documentation regarding authentication for more details https://developers.greenhouse.io/harvest.html#authentication | ||
| sensitive: True | ||
| - name: greenhouse_user_id | ||
| label: Your Greenhouse USER id. This value can be seen by any Greenhouse user from the main page by examining the URL when viewing this user. From the Greenhouse main page, navigate to Configure -> Users -> Select the desired user. The URL when viewing the account will look like this https://app8.greenhouse.io/account/users/4054555008/edit where the numeric value is the Greenhouse user ID. |
There was a problem hiding this comment.
The label value should be the user-friendly version of domain, api_key, and greenhouse_user_id so Domain, Api Key and Greenhouse user ID. The text you have there is better suited for the description
galvana
reviewed
Jun 4, 2024
galvana
added
the
run unsafe ci checks
galvana
approved these changes
Jun 11, 2024
galvana
reviewed
Jun 11, 2024
| direction: from | ||
| query_params: | ||
| - name: fields | ||
| value: "full_name,current_company,current_title,tags,phone_numbers,emails,social_media_links,websites,addresses,location,custom_candidate_fields,source,recruiter,coordinator,attachments,application_questions,referral_questions,notes,rejection_notes,email_addresses,activity_items,innotes,inmails,rejection_reason,scorecards_and_interviews,offers,credited_to,headline,all_offer_versions,follow_up_reminders,custom_application_fields,education,employment,candidate_stage_data,prospect_owner,custom_rejection_question_fields,touchpoints,prospect_pool_and_stage,prospect_jobs,prospect_offices,prospect_offices_and_departments,third_party_integrations" |
There was a problem hiding this comment.
In the future, we could make this more dynamic by using the keys of the masked_object_fields map as the query params
Passing run #8261 ↗︎
Details:
Review all test suite changes for PR #4945 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description Of Changes
Added integration for Greenhouse Harvest. This integration includes access and erasure. A note about the erasure here is that we are using the Harvest API Anonymize endpoint.
Code Changes
Steps to Confirm
Pre-Merge Checklist
https://github.com/ethyca/fidesdocs/pull/375
https://github.com/ethyca/fidesdocs/issues/374
CHANGELOG.md