Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScyllaDB Connector #4946
ScyllaDB Connector #4946
Changes from 15 commits
d413965
ffae8fb
9fcd343
74482a1
8e2c662
2c9ba3b
64649b9
53096c0
359f17e
9ac58a5
a1f65bb
ab1411a
c99c485
6e150f5
8529093
436faab
d35eed5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 41 in src/fides/api/service/connectors/scylla_connector.py
Codecov / codecov/patch
src/fides/api/service/connectors/scylla_connector.py#L41
Check warning on line 62 in src/fides/api/service/connectors/scylla_connector.py
Codecov / codecov/patch
src/fides/api/service/connectors/scylla_connector.py#L61-L62
Check warning on line 72 in src/fides/api/service/connectors/scylla_connector.py
Codecov / codecov/patch
src/fides/api/service/connectors/scylla_connector.py#L70-L72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: worth raising a
NotImplementedError
here? that always feels like the most proper thing, just to make it transparent to anyone who somehow hits the codepath at runtime without reading the codebase, but maybe i'm overthinking it :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now i'm wondering whether raising the error may unexpectedly impact other DSR workflows and i shouldn't be doing that... π€
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are datasets for the connection config this could get picked up in a DSR I believe!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep confirmed a NotImplementedError will break DSR's if a dataset is also attached to the ConnectionConfig .