Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2058: Implement API endpoints for property-specific messaging (WIP) #4974

Closed
wants to merge 61 commits into from

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Jun 11, 2024

Closes https://ethyca.atlassian.net/browse/PROD-2058

Note- #4950 must be merged first!

Description Of Changes

Implements API endpoints for property-specific messaging. The following new endpoints were added:

  • GET /messaging/templates/summary- get paginated list of all existing templates in the DB
  • GET /messaging/templates/default/{template_type}- get the default messaging template by type. This is not dependent on the DB at all, rather hard-coded in the BE.
  • POST /messaging/templates/{template_type}- create a new messaging template . Use req body formatted like:
content: Dict[str, Any]
properties: Optional[List[str]]
is_enabled: bool
  • PUT /messaging/templates/{id}- update an existing messaging template. Use req body formatted like:
content: Dict[str, Any]
properties: Optional[List[str]]
is_enabled: bool
  • GET /messaging/templates/{id}- get an existing messaging template by id
  • DELETE /messaging/templates/{id} - delete a messaging template by id

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 2:34pm

Base automatically changed from PROD-2049-cherry-pick to main June 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant