Disable GPP stub when initialize=false is set until Fides.init() is called
#5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gilluminate
force-pushed
the
gill/PROD-2214_mediavine-disable-gpp-stub
branch
from
2ec6b24 to
6a69e36
Compare
Passing run #8427 ↗︎
Details:
Review all test suite changes for PR #5010 ↗︎ |
||||||||||||||||||||
gilluminate
commented
Jun 19, 2024
Comment on lines
-293
to
-295
| isTestMode // let end-to-end tests set the config and initialize as needed | ||
| ? "" | ||
| : ` |
There was a problem hiding this comment.
we don't need isTestMode anymore, now that we have intialize=false
gilluminate
commented
Jun 19, 2024
| isTestMode // let end-to-end tests set the config and initialize as needed | ||
| ? "" | ||
| : ` | ||
| var fidesConfig = ${fidesConfigJSON}; |
There was a problem hiding this comment.
no longer prints the config twice
gilluminate
commented
Jun 19, 2024
Comment on lines
-23
to
-26
| (function () { | ||
| if (window.fidesConfig?.experience?.gpp_settings?.enabled) | ||
| document.write('<script src="./lib/fides-ext-gpp.js"><\/script>'); | ||
| })(); |
There was a problem hiding this comment.
handled using query params now that gppEnabled is on the config object
Passing run #8428 ↗︎
Details:
Review all test suite changes for PR #5010 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2214
Description Of Changes
Initializing GPP without initializing Fides has been known to cause issues, especially in cases where Fides never gets initialized.
initialize=false, ensure that GPP is not initialized at allFides.init()is called, ensure that the GPP stub is initialized promptly and is not delayed by any other blocking logic (e.g. API calls, etc.)Code Changes
fides.jsresponse by not printing config object twice.gppEnabledas part of the config options object (similar to existingtcfEnabled)FidesInitializingevent for benefit of GPP initialization and other similar use casesFidesInitializingto be dispatched before initializing GPP.Steps to Confirm
initializeset to false (eg./fides-js-demo.html?gpp=true&initialize=false)__gpp('ping', (data) => {console.log(data)})__gppdoes not exist yet.window.Fides.init()__gpp('ping', (data) => {console.log(data)})Pre-Merge Checklist
CHANGELOG.md