Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2230: Fix table cell formatting for vendors #5013

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Jun 20, 2024

Closes https://ethyca.atlassian.net/browse/PROD-2230

Description Of Changes

Adds new re-usable component to display badges in table cells where we only have count (number) to work with, instead of the value names.

Code Changes

  • Update vendor table to use new component.

Steps to Confirm

Screenshot 2024-06-20 at 5 51 55 PM

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 4:03pm

Copy link

cypress bot commented Jun 20, 2024

Passing run #8439 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge bab04f1 into 0c0f37d...
Project: fides Commit: 0d6e3ac5ae ℹ️
Status: Passed Duration: 00:34 💡
Started: Jun 20, 2024 4:12 PM Ended: Jun 20, 2024 4:12 PM

Review all test suite changes for PR #5013 ↗︎

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this works great for now. I'd like to see us create a better system for displaying cells and badges in general, but that's outside of the scope of this fix.

@eastandwestwind eastandwestwind merged commit c34d3c7 into main Jun 20, 2024
13 checks passed
@eastandwestwind eastandwestwind deleted the PROD-2230 branch June 20, 2024 16:50
@cypress cypress bot mentioned this pull request Jun 20, 2024
31 tasks
Copy link

cypress bot commented Jun 20, 2024

Passing run #8441 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

PROD-2230: Fix table cell formatting for vendors (#5013)
Project: fides Commit: c34d3c7af0
Status: Passed Duration: 00:33 💡
Started: Jun 20, 2024 5:03 PM Ended: Jun 20, 2024 5:03 PM

Review all test suite changes for PR #5013 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants