PROD-2254: User must have delete scope to delete systems #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
eastandwestwind
force-pushed
the
PROD-2254
branch
from
e5cd7fb to
74606df
Compare
pattisdr
reviewed
Jun 28, 2024
…ng the function that lets data stewards delete systems. - Fides_key should be a string now - Revert to using "verify_oauth_client_prod"
pattisdr
reviewed
Jun 28, 2024
Passing run #8605 ↗︎
Details:
Review all test suite changes for PR #5037 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5037 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 352 352
Lines 21882 21882
Branches 2885 2885
=======================================
Hits 18938 18938
Misses 2438 2438
Partials 506 506 ☔ View full report in Codecov by Sentry. |
eastandwestwind
commented
Jun 28, 2024
pattisdr
approved these changes
Jun 28, 2024
Passing run #8626 ↗︎
Details:
Review all test suite changes for PR #5037 ↗︎ |
|||||||||||||||
Kelsey-Ethyca
pushed a commit
that referenced
this pull request
Jul 3, 2024
Co-authored-by: Dawn Pattison <pattisdr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-2254
Description Of Changes
Remove "OR" condition in the security of Delete Systems endpoint such that we only check for users with the "SYSTEM_DELETE" scope explicitly.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works