Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2046 Fix bug where messaging option appear to viewer roles #5053

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

lucanovera
Copy link
Contributor

Description Of Changes

Fix bug where messaging option appear to viewer roles

Code Changes

  • Change in nav-config.ts the required scopes to be MESSAGING_CREATE_OR_UPDATE

Steps to Confirm

  • Log in as Viewer user
  • Check that the navigation doesn't include messaging under settings

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 1:44pm

Copy link

cypress bot commented Jul 2, 2024

Passing run #8731 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 1fade9c into db59002...
Project: fides Commit: 1c3763e435 ℹ️
Status: Passed Duration: 00:40 💡
Started: Jul 3, 2024 1:53 PM Ended: Jul 3, 2024 1:54 PM

Review all test suite changes for PR #5053 ↗︎

@lucanovera lucanovera merged commit 2c3c926 into main Jul 3, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2046_fix-messaging-nav-roles branch July 3, 2024 13:54
Copy link

cypress bot commented Jul 3, 2024

Passing run #8734 ↗︎

0 4 0 0 Flakiness 0

Details:

PROD-2046 Fix bug where messaging option appear to viewer roles (#5053)
Project: fides Commit: 2c3c926478
Status: Passed Duration: 00:40 💡
Started: Jul 3, 2024 2:06 PM Ended: Jul 3, 2024 2:07 PM

Review all test suite changes for PR #5053 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants