Fix issue with monitor results pagination

[jpople]

Closes #PROD-2233

Description Of Changes

Fixes a bug where, when switching between pages using the result tables' pagination menu or searching, results from previous table views were remaining on the table.

Loom demonstrating bugged behavior

Loom demonstrating fixed behavior

The issue was that the key prop, which is used by React to determine which rows to clear when rerendering, wasn't unique enough-- if a result on page A had the same name as a result on page B, its row would stay on the table instead of being removed. I fixed this by making all discovery/detection tables also include their monitor config ID in their row ID (from which the key is derived).

Code Changes

• Unify getRowId across all D&D tables
• Change getRowId to include monitor config ID
• Update (a lot of) tests to use changed data-testids

Steps to Confirm

• Create several discovery monitors for integrations that have data (I used S3)
• Execute all monitors until there are >25 results
• View results in "Activity" and "Detection" tables
• Should be able to switch pages and search
• Table should show only the 25 results per page that are supposed to be populated

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Issue Requirements are Met
• Update CHANGELOG.md

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Jul 3, 2024 6:41pm

[lucanovera]

Good fix! Appreciate the loom videos too. Approve

[cypress]

Passing run #8760 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 6c7d473 into 182ffe7...
Project: fides	Commit: 8aa598d3b6 ℹ️
Status: Passed	Duration: 00:42 💡
Started: Jul 3, 2024 6:56 PM	Ended: Jul 3, 2024 6:56 PM

Review all test suite changes for PR #5060 ↗︎

[cypress]

Passing run #8762 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Fix issue with monitor results pagination (#5060)
Project: fides	Commit: b2d94fa770
Status: Passed	Duration: 00:42 💡
Started: Jul 3, 2024 7:13 PM	Ended: Jul 3, 2024 7:14 PM

Review all test suite changes for PR #5060 ↗︎