Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra install keyword #5086

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Remove extra install keyword #5086

merged 3 commits into from
Jul 16, 2024

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Jul 16, 2024

Closes Unticketed

Description Of Changes

Same issues that were fixed in https://github.com/ethyca/fidesplus/pull/1511

Code Changes

  • Removes extra install

Steps to Confirm

  • Confirm CI succeeds

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 6:22pm

Copy link

cypress bot commented Jul 16, 2024

Passing run #8930 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d235d89 into e63a74f...
Project: fides Commit: db1c74f115 ℹ️
Status: Passed Duration: 00:37 💡
Started: Jul 16, 2024 6:33 PM Ended: Jul 16, 2024 6:33 PM

Review all test suite changes for PR #5086 ↗︎

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (e63a74f) to head (d235d89).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5086   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files         357      357           
  Lines       22302    22302           
  Branches     2946     2946           
=======================================
  Hits        19293    19293           
  Misses       2495     2495           
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucanovera lucanovera merged commit a03a8f6 into main Jul 16, 2024
45 checks passed
@lucanovera lucanovera deleted the fix-ci branch July 16, 2024 18:50
Copy link

cypress bot commented Jul 16, 2024

Passing run #8931 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Remove extra install keyword (#5086)
Project: fides Commit: a03a8f68f4
Status: Passed Duration: 00:37 💡
Started: Jul 16, 2024 7:01 PM Ended: Jul 16, 2024 7:02 PM

Review all test suite changes for PR #5086 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants