Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert moving messaging template endpoints #5093

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

eastandwestwind
Copy link
Contributor

Closes Unticketed

Description Of Changes

https://github.com/ethyca/fidesplus/pull/1505 needs further debugging, so we have to revert the fides portion (#5069)

Code Changes

Steps to Confirm

  • Confirm no new regressions with property-specific messaging

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 5:48pm

Copy link

cypress bot commented Jul 17, 2024

Passing run #8973 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8f9c07b into f390fc9...
Project: fides Commit: 44e7252164 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 17, 2024 5:59 PM Ended: Jul 17, 2024 6:00 PM

Review all test suite changes for PR #5093 ↗︎

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (f390fc9) to head (8f9c07b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5093      +/-   ##
==========================================
+ Coverage   86.47%   86.50%   +0.03%     
==========================================
  Files         357      357              
  Lines       22271    22302      +31     
  Branches     2944     2946       +2     
==========================================
+ Hits        19258    19293      +35     
+ Misses       2498     2495       -3     
+ Partials      515      514       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approvedd

@eastandwestwind eastandwestwind merged commit fc2ea32 into main Jul 17, 2024
51 checks passed
@eastandwestwind eastandwestwind deleted the revert-PROD-2211 branch July 17, 2024 18:31
Copy link

cypress bot commented Jul 17, 2024

Passing run #8977 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

revert moving messaging template endpoints (#5093)
Project: fides Commit: fc2ea32ce1
Status: Passed Duration: 00:35 💡
Started: Jul 17, 2024 6:42 PM Ended: Jul 17, 2024 6:42 PM

Review all test suite changes for PR #5093 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants