-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2211 moves some property-specific endpoints from OSS -> plus #5096
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #9137 ↗︎
Details:
Review all test suite changes for PR #5096 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5096 +/- ##
==========================================
- Coverage 86.56% 86.54% -0.03%
==========================================
Files 357 357
Lines 22349 22318 -31
Branches 2955 2953 -2
==========================================
- Hits 19347 19315 -32
Misses 2480 2480
- Partials 522 523 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good and the UI works just fine with the new endpoints - adding, deleting, editing, enabling. Approved! 💯
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Closes https://ethyca.atlassian.net/browse/PROD-2211 (Fides portion)
Description Of Changes
Moves some endpoints from property-specific messaging from OSS -> plus, in additon to relevant tests.
Not all endpoints used by property-specific messaging feature have been moved, because some are more generic endpoints that can be used by either basic or property-specific messaging (get/delete template by id for example).
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works