Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2211 moves some property-specific endpoints from OSS -> plus #5096

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

eastandwestwind
Copy link
Contributor

Closes https://ethyca.atlassian.net/browse/PROD-2211 (Fides portion)

Description Of Changes

Moves some endpoints from property-specific messaging from OSS -> plus, in additon to relevant tests.

Not all endpoints used by property-specific messaging feature have been moved, because some are more generic endpoints that can be used by either basic or property-specific messaging (get/delete template by id for example).

Code Changes

  • Moves code from OSS -> plus

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 0:18am

Copy link

cypress bot commented Jul 18, 2024

Passing run #9137 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5f11681 into 14211e3...
Project: fides Commit: 3819945caa ℹ️
Status: Passed Duration: 00:37 💡
Started: Jul 25, 2024 12:26 PM Ended: Jul 25, 2024 12:26 PM

Review all test suite changes for PR #5096 ↗︎

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (14211e3) to head (5f11681).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5096      +/-   ##
==========================================
- Coverage   86.56%   86.54%   -0.03%     
==========================================
  Files         357      357              
  Lines       22349    22318      -31     
  Branches     2955     2953       -2     
==========================================
- Hits        19347    19315      -32     
  Misses       2480     2480              
- Partials      522      523       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good and the UI works just fine with the new endpoints - adding, deleting, editing, enabling. Approved! 💯

@eastandwestwind eastandwestwind merged commit 139d0a6 into main Jul 30, 2024
57 checks passed
@eastandwestwind eastandwestwind deleted the PROD-2211-rework branch July 30, 2024 12:32
Copy link

cypress bot commented Jul 30, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 139d0a6
Started Jul 30, 2024 12:44 PM
Ended Jul 30, 2024 12:45 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants